Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Product Partnerships] Added Amazon Database Migration Service #2124

Merged
merged 7 commits into from
Nov 1, 2023
Merged

[Product Partnerships] Added Amazon Database Migration Service #2124

merged 7 commits into from
Nov 1, 2023

Conversation

SuruchiSaboo
Copy link
Contributor

[Product Partnerships] Added Amazon DMS Entity

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@seemantk seemantk added the northstar Created by Project NorthStar label Oct 20, 2023
rahulbasu-nr
rahulbasu-nr reviewed Oct 23, 2023
View reviewed changes
alert-policies/amazon-database-migration-service/LowFreeableMemory.yml Outdated
name: Low Freeable Memory

description: |+
This alert occurs when Freeable Memory bytes go below 100 for 5 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 100? Please specify the unit of measurement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review.

rahulbasu-nr
rahulbasu-nr suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes.

alert-policies/amazon-database-migration-service/LowFreeableMemory.yml Show resolved Hide resolved
alert-policies/amazon-database-migration-service/LowFreeableMemory.yml Show resolved Hide resolved
alert-policies/amazon-database-migration-service/LowFreeableMemory.yml Show resolved Hide resolved
quickstarts/aws/amazon-database-migration-service/config.yml Outdated Show resolved Hide resolved
@SuruchiSaboo SuruchiSaboo changed the title [Product Partnerships] Added Amazon DMS Entity [Product Partnerships] Added Amazon Database Migration Service Oct 25, 2023
rahulbasu-nr
rahulbasu-nr approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pkosanam pkosanam merged commit 4b9b599 into newrelic:main Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulbasu-nr rahulbasu-nr rahulbasu-nr approved these changes

@seemantk seemantk Awaiting requested review from seemantk

Assignees
No one assigned
Labels
new-quickstart northstar Created by Project NorthStar product partnerships waiting on contributor
Projects
NR1 Quickstarts Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuruchiSaboo @rahulbasu-nr @seemantk @zstix @pkosanam